Closed
Conversation
aphralG
reviewed
Sep 30, 2025
|
|
||
| # Run watcher tests with CPU profiling for each package | ||
| echo "Starting watcher tests with cpu profiling..." | ||
| packages=$(find internal/watcher -type f -name '*_test.go' -exec dirname {} \; | sort -u) |
Contributor
There was a problem hiding this comment.
Do we need to add a script? Could this be done in the make file ?
Contributor
Author
There was a problem hiding this comment.
It probably could but it's much nicer to do it in bash vs Makefile. If we expand our profiling later I don't want to bloat these Makefiles
Contributor
There was a problem hiding this comment.
Ok I'm just not the biggest fan of adding scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds a new workflow
Generate CPU Profile, which runs our load and watcher tests with the-cpuprofileflag enabled. This creates several output files with the.pprofextension which will be merged into a singledefault.pgofile which we can use on subsequent builds of Agent to make use of the optimisations.On running this job, it will create a new branch with the altered
default.pgo. It will also create a PR back into the original branch it was executed on.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)